> On Sept. 10, 2012, 5:48 p.m., Brock Noland wrote: > > flume-ng-core/src/main/java/org/apache/flume/sink/NullSink.java, line 99 > > <https://reviews.apache.org/r/6986/diff/1/?file=152262#file152262line99> > > > > It looks like this would work. I wonder if a % would be more readable?
I could do it that way, but then I have to check on every take. I was trying to only do it on commits. I don't think % will work for commits. I will upload a patch that uses %. Give me a minute. - Ted ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6986/#review11254 ----------------------------------------------------------- On Sept. 10, 2012, 5:56 p.m., Ted Malaska wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6986/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2012, 5:56 p.m.) > > > Review request for Flume. > > > Description > ------- > > Adding the ability to log.info counts at the end of a transaction if a > threshold of logEveryNEvents is met. > > Default value for logEveryNEvents is 10k but it can be configured. > > > This addresses bug FLUME-1556. > https://issues.apache.org/jira/browse/FLUME-1556 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/sink/NullSink.java 5cc1521 > > Diff: https://reviews.apache.org/r/6986/diff/ > > > Testing > ------- > > > Thanks, > > Ted Malaska > >
