----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7020/#review11332 -----------------------------------------------------------
Ship it! Ship It! - Brock Noland On Sept. 11, 2012, 3:29 p.m., Ted Malaska wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7020/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2012, 3:29 p.m.) > > > Review request for Flume. > > > Description > ------- > > It is possible that it is a clock issue. > > because s2 has to wait 2000 mil/s because of the following line > state.restoreTime = now + Math.min(MAX_TIMEOUT, 1000 * (1 << > state.sequentialFails)); > > But then the test waits 2000 mil/s before starting the loop again. > > There is a chance that we reach the following if statement at only 2000 mil/s > passing > > if (state.restoreTime < curTime) { > > So I'm going to increase the wait to 2001 mil/s. That should do it. > > > This addresses bug FLUME-1562. > https://issues.apache.org/jira/browse/FLUME-1562 > > > Diffs > ----- > > > flume-ng-core/src/test/java/org/apache/flume/sink/TestLoadBalancingSinkProcessor.java > 981f88e > > Diff: https://reviews.apache.org/r/7020/diff/ > > > Testing > ------- > > > Thanks, > > Ted Malaska > >
