----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6998/#review11407 -----------------------------------------------------------
Nice work! There were a couple of test failures, where you wouldn't expect, due to this change. Can you address the comments below? flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java <https://reviews.apache.org/r/6998/#comment24445> Many tests use this source and were not calling configure on it. I think this check should be if (batchSize <= 1) flume-ng-core/src/test/java/org/apache/flume/source/TestSequenceGeneratorSource.java <https://reviews.apache.org/r/6998/#comment24446> Nit: Can you wrap this line to 80 chars? flume-ng-core/src/test/java/org/apache/flume/source/TestSequenceGeneratorSource.java <https://reviews.apache.org/r/6998/#comment24447> Nit: Since we know we passing in a string, lets just compare the strings as opposed to the byte arrrays - Brock Noland On Sept. 11, 2012, 1:07 a.m., Ted Malaska wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6998/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2012, 1:07 a.m.) > > > Review request for Flume. > > > Description > ------- > > Added the config "batchSize". This will define the event batch size. > Patch includes junits > > > This addresses bug FLUME-1557. > https://issues.apache.org/jira/browse/FLUME-1557 > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java > 440c5a9 > > flume-ng-core/src/test/java/org/apache/flume/source/TestSequenceGeneratorSource.java > 89dbeb2 > > Diff: https://reviews.apache.org/r/6998/diff/ > > > Testing > ------- > > > Thanks, > > Ted Malaska > >
