----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7022/#review11408 -----------------------------------------------------------
Just one thought on using SinkCounter. flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java <https://reviews.apache.org/r/7022/#comment24448> Mike said on the list CounterGroup is legacy. Should we use SinkCounter so that the metrics will be pushed to the JMX interface? - Brock Noland On Sept. 11, 2012, 5:11 p.m., Ted Malaska wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7022/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2012, 5:11 p.m.) > > > Review request for Flume. > > > Description > ------- > > Added counting for: > 1. events > 2. transaction success > 3. transaction failure > Also added logging of name and counters at start and stop. Just like NullSink. > > > This addresses bug FLUME-1537. > https://issues.apache.org/jira/browse/FLUME-1537 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java > e5e97ff > > Diff: https://reviews.apache.org/r/7022/diff/ > > > Testing > ------- > > > Thanks, > > Ted Malaska > >
