> On Sept. 12, 2012, 6:52 p.m., Mike Percy wrote: > > Why not use a ThreadLocal instead of a pool?
That is just a general question, patch looks good, +1 from me - Mike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7044/#review11419 ----------------------------------------------------------- On Sept. 11, 2012, 10:37 p.m., Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7044/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2012, 10:37 p.m.) > > > Review request for Flume. > > > Description > ------- > > Decryption did not use a pool of Decryptors, with this patch it does. > > FYI: I created FLUME-1566 to remove the hack of an initialize method. It's > there due some screwy logic in roll, creating the random reader before the > log writer, which we should fix. > > > This addresses bug FLUME-1565. > https://issues.apache.org/jira/browse/FLUME-1565 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileV3.java > 414d6d9 > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/encryption/TestFileChannelEncryption.java > 5f3a23d > > Diff: https://reviews.apache.org/r/7044/diff/ > > > Testing > ------- > > Unit tests pas, one regression test added, along with an additional unit test. > > > Thanks, > > Brock Noland > >
