----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7041/#review11423 -----------------------------------------------------------
Ship it! +1. - Hari Shreedharan On Sept. 11, 2012, 9:06 p.m., Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7041/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2012, 9:06 p.m.) > > > Review request for Flume. > > > Description > ------- > > Moves the logic to test if a file exists before crating a Log Writer to > LogFileFactory and tests to make sure it works. > > > This addresses bug FLUME-1564. > https://issues.apache.org/jira/browse/FLUME-1564 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java > f834148 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileFactory.java > 7bf6de4 > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLogFile.java > 1efdb80 > > Diff: https://reviews.apache.org/r/7041/diff/ > > > Testing > ------- > > Existing unit tests pass and new unit tests added. > > > Thanks, > > Brock Noland > >
