> On Sept. 5, 2012, 5:29 p.m., Mike Percy wrote: > > flume-ng-core/src/main/java/org/apache/flume/instrumentation/ChannelCounter.java, > > line 111 > > <https://reviews.apache.org/r/6920/diff/1/?file=149641#file149641line111> > > > > We may want to return 100.0 so that graphs tracking these metrics don't > > get out of whack > > Hari Shreedharan wrote: > Not really. If the channel capacity is 0, something is messed up. Ideally > it should never reach this line of code. So I'd rather leave it at this to > show that there is a major issue. > > Hari Shreedharan wrote: > 100% is a valid value, while Double.MAX_VALUE is not. This shows that > there is something wrong, which it should signify.
It's a really broken configuration case that's for sure. I think it will make % graphs look really messed up but it's not a big deal. - Mike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6920/#review11067 ----------------------------------------------------------- On Sept. 5, 2012, 7:01 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6920/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2012, 7:01 a.m.) > > > Review request for Flume. > > > Description > ------- > > Added support for channel fill percentage. > > > This addresses bug FLUME-1538. > https://issues.apache.org/jira/browse/FLUME-1538 > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/instrumentation/ChannelCounter.java > 602481e > > flume-ng-core/src/main/java/org/apache/flume/instrumentation/ChannelCounterMBean.java > f0c3ef3 > > Diff: https://reviews.apache.org/r/6920/diff/ > > > Testing > ------- > > Did functional testing. > > > Thanks, > > Hari Shreedharan > >
