-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6977/
-----------------------------------------------------------
(Updated Sept. 12, 2012, 11:04 p.m.)
Review request for Flume.
Changes
-------
Removed a bunch of unused imports, cleaned up whitespaces and add some comments
explaining the logic.
Description
-------
Added backoff functionality to load balancing rpc clients. Refactored much of
the Load balancing code and removed much of the copy paste code. Modified the
sink processors to take backoff as a config, than having additional sink
processor for backoff.
Note that the (public) SinkSelector interface was changed to support backoff,
the same change was made in the HostSelector interface in the sdk as well.
This addresses bug FLUME-1488.
https://issues.apache.org/jira/browse/FLUME-1488
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/sink/AbstractSinkSelector.java
3e806a7
flume-ng-core/src/main/java/org/apache/flume/sink/LoadBalancingSinkProcessor.java
93a46a0
flume-ng-core/src/test/java/org/apache/flume/sink/TestLoadBalancingSinkProcessor.java
e0705bf
flume-ng-sdk/pom.xml 75acacd
flume-ng-sdk/src/main/java/org/apache/flume/api/LoadBalancingRpcClient.java
b04e0f0
flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientConfigurationConstants.java
72666a6
flume-ng-sdk/src/main/java/org/apache/flume/util/OrderSelector.java
PRE-CREATION
flume-ng-sdk/src/main/java/org/apache/flume/util/RandomOrderSelector.java
PRE-CREATION
flume-ng-sdk/src/main/java/org/apache/flume/util/RoundRobinOrderSelector.java
PRE-CREATION
flume-ng-sdk/src/test/java/org/apache/flume/api/TestLoadBalancingRpcClient.java
10474cb
Diff: https://reviews.apache.org/r/6977/diff/
Testing
-------
Added unit tests based on Load balancing sink processor's unit tests.
Thanks,
Hari Shreedharan
