----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7086/#review11490 -----------------------------------------------------------
Hari, thank you very much for the patch. Once comment below flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java <https://reviews.apache.org/r/7086/#comment24612> I don't see the sync() call? Why not keep the call to elementsBuffer and then use it's force() method? - Brock Noland On Sept. 13, 2012, 6:54 p.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7086/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2012, 6:54 p.m.) > > > Review request for Flume. > > > Description > ------- > > CHECKPOINT_INCOMPLETE will now be written synchronously to disk before > starting checkpoint. > > > This addresses bug FLUME-1576. > https://issues.apache.org/jira/browse/FLUME-1576 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java > 4717055 > > Diff: https://reviews.apache.org/r/7086/diff/ > > > Testing > ------- > > > Thanks, > > Hari Shreedharan > >
