> On Sept. 13, 2012, 9:27 p.m., Mike Percy wrote: > > Some minor inconsistency is still there that can be addressed in a future > > patch. It looks like the keys list is not required if the keys don't have a > > password, which makes sense. However you have to specify something or else > > it complains: > > > > java.lang.IllegalStateException: Keys available to KeyStore was not > > specified or empty > > > > But you can just specify junk there and it works fine if activeKey is in > > the keyStore and doesn't require a password. I don't think this is a big > > deal though and I'm going to commit this patch.
I created https://issues.apache.org/jira/browse/FLUME-1579 for this - Brock ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7087/#review11505 ----------------------------------------------------------- On Sept. 13, 2012, 9:02 p.m., Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7087/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2012, 9:02 p.m.) > > > Review request for Flume. > > > Description > ------- > > Implements the proposal in FLUME-1578. > > > This addresses bug FLUME-1578. > https://issues.apache.org/jira/browse/FLUME-1578 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java > 4717055 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java > 66f7536 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/encryption/EncryptionConfiguration.java > 27716fc > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/encryption/KeyProviderFactory.java > f09c48b > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestEventQueueBackingStoreFactory.java > 1fc9b49 > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/encryption/EncryptionTestUtils.java > fc617f5 > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/encryption/TestFileChannelEncryption.java > a0037b8 > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/encryption/TestJCEFileKeyProvider.java > 14afaeb > > Diff: https://reviews.apache.org/r/7087/diff/ > > > Testing > ------- > > Unit tests pass including one testing the configuration. > > > Thanks, > > Brock Noland > >
