> On Sept. 14, 2012, 8:44 p.m., Mike Percy wrote: > > We need to find another way to do it than make it synchronized. That would > > kill multithreaded performance. > > Ted Malaska wrote: > You mean on the put? Hmm let me think about it > > Ted Malaska wrote: > How about a on the first if statement getAndAdd(+eventSize) and a > getAndAdd(-eventSize) if the event doesn't get into the queue?
Talked with Mike Here is the plan for the weekend 1. Change the put logic to not use sync but a getAndAdd(+EventSize) at the time of if and getAndAdd(-eventSize_ if there is a failure getting into the queue 2. Single a log.info if config doesn't have memory limit set. - Ted ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6982/#review11563 ----------------------------------------------------------- On Sept. 14, 2012, 2 p.m., Ted Malaska wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6982/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2012, 2 p.m.) > > > Review request for Flume. > > > Description > ------- > > 1. The user will be able to define a byteCapacity and a > byteCapacityBufferPercentage. > 2. Events byte size will be estimated from there body contents > 3. On put bytes are added to current total > 4. On commit any uncommitted takes are removed from the current byte total > 5. On rollover any uncommitted puts are removed from the current byte total > > > This addresses bug FLUME-1535. > https://issues.apache.org/jira/browse/FLUME-1535 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java > c72e97c > flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannel.java > e070864 > > Diff: https://reviews.apache.org/r/6982/diff/ > > > Testing > ------- > > > Thanks, > > Ted Malaska > >
