----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7141/#review11649 -----------------------------------------------------------
flume-ng-channels/flume-file-channel/pom.xml <https://reviews.apache.org/r/7141/#comment25167> I know this is not exactly extensible. We can use fancier shell techniques to find out which ".java" file is generated and insert the ASL into that. But as of now, I don't think it is needed. If we do need it at some point, we shall revisit this. - Hari Shreedharan On Sept. 18, 2012, 3:14 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7141/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2012, 3:14 a.m.) > > > Review request for Flume. > > > Description > ------- > > Submitting this for early review. There are empty blocks of code which say > "Do something etc." Those will be filled in before this is in any commit-able > shape. This is being submitted now to get some early feedback on the logic. > Also, I didn't include the checksum in TxnEventFooter, since that will > unnecessarily be included(even if marked as optional, I wasn't sure whether > protos will generate something for it - also, including it in only in Puts > helps avoid confusion). As of this patch, the checksum is only on the event > body. This can be expanded later if the need arises. > > > This addresses bug FLUME-1586. > https://issues.apache.org/jira/browse/FLUME-1586 > > > Diffs > ----- > > flume-ng-channels/flume-file-channel/pom.xml 658c06f > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/CheckpointRebuilder.java > 748f49a > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java > c2e904b > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannelConfiguration.java > be2f633 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Put.java > d47b1c8 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/ReplayHandler.java > 81f6172 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/proto/ProtosFactory.java > e6d4957 > flume-ng-channels/flume-file-channel/src/main/proto/filechannel.proto > 3a4e828 > flume-ng-channels/flume-file-channel/src/main/resources/ASL20 PRE-CREATION > > Diff: https://reviews.apache.org/r/7141/diff/ > > > Testing > ------- > > None yet. > > > Thanks, > > Hari Shreedharan > >
