-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7177/
-----------------------------------------------------------
Review request for Flume.
Description
-------
This resolves the issue by introducing a special exception
LogFileClosedException which the caller catches when the file has closed and
retries. Additionally LogFileExceededMaxSizeException is introduced. Instead of
making the asynchronous check, an exception is thrown when the max size is
exceeded. The caller than rolls the log to a new writer.
Additionally, the error handling logic has been rolled into one method.
This addresses bug FLUME-1593.
https://issues.apache.org/jira/browse/FLUME-1593
Diffs
-----
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java
e36eafb
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java
8071140
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileClosedException.java
PRE-CREATION
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileMaxLengthExceededException.java
PRE-CREATION
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFileRetryableIOException.java
PRE-CREATION
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java
8baf8fe
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLogExec.java
PRE-CREATION
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLogFile.java
87d9c3f
Diff: https://reviews.apache.org/r/7177/diff/
Testing
-------
New unit tests and old unit tests pass.
Thanks,
Brock Noland
