----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7167/#review11854 -----------------------------------------------------------
Ship it! Ship It! - Hari Shreedharan On Sept. 19, 2012, 3:17 p.m., Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7167/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2012, 3:17 p.m.) > > > Review request for Flume. > > > Description > ------- > > Makes exec source kill it's children when stopping. > > > This addresses bug FLUME-1590. > https://issues.apache.org/jira/browse/FLUME-1590 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/source/AbstractSource.java > 861cc42 > flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java 155f0e2 > > flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceRunner.java > f6c64b3 > flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java > 615f2a3 > > flume-ng-core/src/test/java/org/apache/flume/source/TestMultiportSyslogTCPSource.java > 680e592 > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogParser.java > 258c2f1 > > Diff: https://reviews.apache.org/r/7167/diff/ > > > Testing > ------- > > Adds test to make sure this occurs. > > > Thanks, > > Brock Noland > >
