----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7244/#review11877 -----------------------------------------------------------
Ship it! Ship It! - Mike Percy On Sept. 25, 2012, 4:55 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7244/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2012, 4:55 a.m.) > > > Review request for Flume. > > > Description > ------- > > Rollbacks of Put transactions does not clear the transaction from inflight > puts. This causes files to be not deleted because the channel thinks this > file has active events. InflightEventWrapper is being made > package-private(was private) for testability. > > > This addresses bug FLUME-1606. > https://issues.apache.org/jira/browse/FLUME-1606 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java > ca7db70 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventQueue.java > a8df042 > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java > 41b1fbb > > Diff: https://reviews.apache.org/r/7244/diff/ > > > Testing > ------- > > Added a unit test which will fail without this patch. > > > Thanks, > > Hari Shreedharan > >
