----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7463/#review12382 -----------------------------------------------------------
I think EventBuilder should throw if an event with a null body is passed in. Null body is an invalid event IMO; it requires special handling everywhere, especially when trying to serialize it. - Mike Percy On Oct. 8, 2012, 9:11 p.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7463/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2012, 9:11 p.m.) > > > Review request for Flume. > > > Description > ------- > > Memory channel causes NPE for events with no body. > > > This addresses bug FLUME-1622. > https://issues.apache.org/jira/browse/FLUME-1622 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java > fc3a1e2 > flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannel.java > 4af4a40 > > Diff: https://reviews.apache.org/r/7463/diff/ > > > Testing > ------- > > Added a unit test. > > > Thanks, > > Hari Shreedharan > >
