> On Oct. 12, 2012, 12:07 a.m., Mike Percy wrote: > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java, > > line 242 > > <https://reviews.apache.org/r/7496/diff/1/?file=175021#file175021line242> > > > > We are creating a circular reference here
Agreed, passing in the name is probably enough. > On Oct. 12, 2012, 12:07 a.m., Mike Percy wrote: > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java, > > line 247 > > <https://reviews.apache.org/r/7496/diff/1/?file=175021#file175021line247> > > > > Any drawback to returning this from the authenticate() call? Hmm..Yes. If security is not enabled, we still need to return true from authenticate() - else we cannot log error reliably(if we just check for null being returned from authenticate) to inform of login failure. > On Oct. 12, 2012, 12:07 a.m., Mike Percy wrote: > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/KerberosLoginManager.java, > > line 137 > > <https://reviews.apache.org/r/7496/diff/1/?file=175022#file175022line137> > > > > Probably want the sink name instead of "this" in the log statement Yep. Will do that. - Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7496/#review12378 ----------------------------------------------------------- On Oct. 9, 2012, 7:23 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7496/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2012, 7:23 a.m.) > > > Review request for Flume. > > > Description > ------- > > Refactoring HDFS Sink's kerberos code to another class to make it available > to Hbase sink etc. > > > This addresses bug FLUME-1628. > https://issues.apache.org/jira/browse/FLUME-1628 > > > Diffs > ----- > > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java > 5ec9eb8 > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/KerberosLoginManager.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/7496/diff/ > > > Testing > ------- > > > Thanks, > > Hari Shreedharan > >
