----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7601/#review12583 -----------------------------------------------------------
Looks good in general! A few items below, I will give this a another look later this week. flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchSink.java <https://reviews.apache.org/r/7601/#comment26856> nit: do you mind removing the ws? It shows up red on review board flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchSink.java <https://reviews.apache.org/r/7601/#comment26855> Should we move the defaults into ElasticSearchSinkConstants? - Brock Noland On Oct. 17, 2012, 8:20 p.m., Cameron Gandevia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7601/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2012, 8:20 p.m.) > > > Review request for Flume. > > > Description > ------- > > ElasticSearch sink for flume-ng > > > This addresses bug FLUME-1371. > https://issues.apache.org/jira/browse/FLUME-1371 > > > Diffs > ----- > > flume-ng-dist/pom.xml 3f5dc8c > flume-ng-doc/sphinx/FlumeUserGuide.rst e5f7581 > flume-ng-sinks/flume-ng-elasticsearch-sink/pom.xml PRE-CREATION > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ContentBuilderUtil.java > PRE-CREATION > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchDynamicSerializer.java > PRE-CREATION > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchEventSerializer.java > PRE-CREATION > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchLogStashEventSerializer.java > PRE-CREATION > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchSink.java > PRE-CREATION > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchSinkConstants.java > PRE-CREATION > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/ElasticSearchDynamicSerializerTest.java > PRE-CREATION > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/ElasticSearchLogStashEventSerializerTest.java > PRE-CREATION > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/ElasticSearchSinkTest.java > PRE-CREATION > flume-ng-sinks/pom.xml 06327ba > pom.xml e0ad3b5 > > Diff: https://reviews.apache.org/r/7601/diff/ > > > Testing > ------- > > > Thanks, > > Cameron Gandevia > >
