[ 
https://issues.apache.org/jira/browse/FLUME-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482487#comment-13482487
 ] 

Josh West commented on FLUME-1295:
----------------------------------

I'm very interested in this feature.  Would be nice to have the same dynamic 
path construction for log files going to local filesystems, the same as we have 
with HDFS.

I've tried to apply the first patch to branches "flume-1.3.0" and 
"branch-1.2.0" but it fails:


# patch -p0 < ~/FLUME-1295-A.patch 
patching file 
flume-ng-core/src/main/java/org/apache/flume/sink/AbstractBucketWriter.java
patching file 
flume-ng-core/src/main/java/org/apache/flume/sink/FileBucketWriter.java
patching file 
flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java
Hunk #2 FAILED at 33.
Hunk #3 FAILED at 84.
Hunk #4 FAILED at 102.
Hunk #5 FAILED at 220.
Hunk #6 succeeded at 246 (offset -22 lines).
4 out of 6 hunks FAILED -- saving rejects to file 
flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java.rej
patching file 
flume-ng-core/src/test/java/org/apache/flume/sink/TestRollingFileSink.java
Hunk #3 succeeded at 103 (offset -1 lines).
Hunk #4 succeeded at 176 (offset -3 lines).
patching file 
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java
Hunk #2 succeeded at 46 (offset -2 lines).
Hunk #3 succeeded at 79 (offset -2 lines).
Hunk #4 FAILED at 102.
1 out of 4 hunks FAILED -- saving rejects to file 
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java.rej
patching file 
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
Hunk #1 succeeded at 45 (offset -1 lines).
Hunk #2 succeeded at 96 (offset -1 lines).
Hunk #3 succeeded at 127 (offset -2 lines).
Hunk #4 succeeded at 472 (offset -3 lines).

Do you have any advice on how to get this patch applied?

Thanks.

                
> RollingFileSink need to be able to construct directory path based on escape 
> sequence
> ------------------------------------------------------------------------------------
>
>                 Key: FLUME-1295
>                 URL: https://issues.apache.org/jira/browse/FLUME-1295
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.2.0
>            Reporter: Bhaskar Marthi
>            Assignee: Ted Malaska
>         Attachments: FLUME-1295-A.patch, FLUME-1295-B.patch
>
>
> Currently HDFSEventSink has an ability to construct the directory path based 
> on escape sequence.  It would be beneficial to have similar patch for 
> RollingFileSink for people who just wants to use regular file system.
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to