----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4034/#review12881 -----------------------------------------------------------
Looks good, just small item below flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java <https://reviews.apache.org/r/4034/#comment27689> Why do we re-assign if empty? - Brock Noland On Oct. 29, 2012, 7:18 p.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4034/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2012, 7:18 p.m.) > > > Review request for Flume. > > > Description > ------- > > Support for optional channels in multiplexing channel selector. If no > required channels configured, but there are optional channels then it means, > write to default channels and optionally write to optional channels if they > are available. > > > This addresses bug FLUME-946. > https://issues.apache.org/jira/browse/FLUME-946 > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java > 81dc3e8 > > flume-ng-core/src/test/java/org/apache/flume/channel/TestMultiplexingChannelSelector.java > 2626b20 > flume-ng-doc/sphinx/FlumeUserGuide.rst 0c0951b > > Diff: https://reviews.apache.org/r/4034/diff/ > > > Testing > ------- > > Updated unit tests to support these cases > > > Thanks, > > Hari Shreedharan > >
