-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7780/
-----------------------------------------------------------
(Updated Oct. 30, 2012, 7:10 p.m.)
Review request for Flume.
Changes
-------
Updated JIRA #
Description
-------
The SyslogUtils class doesn't properly parse rfc 3164 style messages containing
a null (hyphen) value. e.g.,
<10>Apr 1 13:14:04 ubuntu-11.cloudera.com - rest_of_message
It tries to parse it as a 5424 style message, skips over the date information,
and interprets the first hyphen as a null timestamp. Part of the problem is the
use of a Scanner and regex. This skips over a properly formatted 3164 style
message until it finds anything that matches the 5424 regex, including a hyphen.
This addresses bug FLUME-1277.
https://issues.apache.org/jira/browse/FLUME-1277
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java 4cded11
flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java
acfb29d
Diff: https://reviews.apache.org/r/7780/diff/
Testing
-------
Unit test added and units pass
Thanks,
Brock Noland
