> On Nov. 9, 2012, 8:01 p.m., Mike Percy wrote: > > This looks good, but I don't see any unit tests that exercise the > > functionality. > > Alexander Alten-Lorenz wrote: > Thats true, missed this. Was patching my local branch with and let run > the build and a simple test. Sry. > > - Ship it, please add a valuable unit test
The main reason I didn't add unit tests was due to the fact that any test would require a handful of sleeps to make sure everything is working as expected, further extending the already long test cycle. I'll have a look at the other testing code and see if I can put some kind of test together without adding too many delays - Juhani ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7659/#review13301 ----------------------------------------------------------- On Nov. 7, 2012, 1:34 a.m., Juhani Connolly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7659/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2012, 1:34 a.m.) > > > Review request for Flume and Mike Percy. > > > Description > ------- > > Added lastWrite to BucketWriter to verify when it was last updated > > Added a thread to HDFSEventSink which verifies the last update of each active > bucketWriter and closes them after the configurable timeout > hdfs.closeIdleTimeout has passed. > > > This addresses bug FLUME-1660. > https://issues.apache.org/jira/browse/FLUME-1660 > > > Diffs > ----- > > flume-ng-doc/sphinx/FlumeUserGuide.rst c1303e0 > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java > 9f2c763 > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java > e369604 > > flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestBucketWriter.java > 6a8072e > > Diff: https://reviews.apache.org/r/7659/diff/ > > > Testing > ------- > > Local machine testing was performed and the correct closing of files was > confirmed, as well as the correct behavior of the configuration setting > including disabling the feature(by using the default value for > hdfs.closeIdleTimeout of 0) > > > There is one unrelated test failure which I'm not sure of(if anyone knows > what's causing this, please let me know) > > Failed tests: testInOut(org.apache.flume.test.agent.TestFileChannel): > Expected FILE_ROLL sink's dir to have only 1 child, but found 0 children. > expected:<1> but was:<0> > > All other tests pass. > > > Thanks, > > Juhani Connolly > >
