Hi, Yeah I don't think these issues require another RC.
The elastic search directory thing should be resolved so the tests don't leave it around (https://issues.apache.org/jira/browse/FLUME-1741) and I do not have an opinion on the .gitignore file other than it is in no way required for a release. Brock On Tue, Nov 27, 2012 at 10:17 AM, Mike Percy <[email protected]> wrote: > Hi Brock, > This is the output I get from an unpacked pristine source tarball and a > pristine (unbuilt) clone of the tag: > > [~/Downloads/flume-1.3.0-rc5/apache-flume-1.3.0-src] > {mpercy@silverdoom}$ diff -rq . ~/src/flume.pristine > Only in /Users/mpercy/src/flume.pristine: .git > Only in /Users/mpercy/src/flume.pristine: .gitignore > Only in /Users/mpercy/src/flume.pristine: contrib > Only in ./flume-ng-sinks/flume-ng-elasticsearch-sink: data > Only in ./flume-ng-tests: .classpath > Only in ./flume-ng-tests: .project > Only in ./flume-ng-tests: .settings > > .git should not be in the tarball obviously so that's fine, .gitignore > doesn't have functionality for Flume but it's checked in and tagged - so > theoretically we should include it I believe, contrib is an OG straggler > and should be removed from the source tree altogether, and I guess an empty > directory from elastic search and a few generated files were included in > the tarball. > > I just filed a JIRA and attached a patch to delete contrib/ from trunk: > https://issues.apache.org/jira/browse/FLUME-1740 > > IMHO, it's not worth rolling another RC for any of this stuff. It could be > worth documenting this check on the release checklist for the next release > cycle though. > > Regards, > Mike > > > On Tue, Nov 27, 2012 at 7:29 AM, Brock Noland <[email protected]> wrote: > > > What dotfiles are you seeing as missing? > > > > I see .classpath, .project, and .settings but those are generated by > maven > > and should not be included. I do see a missing .gitignore but I don't > think > > that should be included as the tar ball is not managed by git. > > > > Brock > > > > On Tue, Nov 27, 2012 at 2:25 AM, Mike Percy <[email protected]> wrote: > > > > > +1 for rc5 > > > > > > * Verified signatures & checksums of both artifacts > > > * Unit tests pass > > > * Binary artifact runs, built source artifact runs > > > * LICENSE, NOTICE, and CHANGELOG files look good > > > * Did a diff -rq between the tag and the source artifact. Only missing > a > > > few dotfiles at the top level in the source artifact. I think that's > > > alright, but maybe we should fix it for 1.4? > > > > > > Nice work, Brock! Thanks for managing this release! > > > > > > Regards, > > > Mike > > > > > > > > > On Wed, Nov 21, 2012 at 11:07 AM, Brock Noland <[email protected]> > > wrote: > > > > > > > This is the second release for Apache Flume as a top-level project, > > > > version 1.3.0. We are voting on release candidate rc5. > > > > > > > > *** Please cast your vote within the next 72 hours *** > > > > > > > > The list of fixed issues: > > > > http://s.apache.org/RoN > > > > > > > > The tarball (*.tar.gz), signature (*.asc), and checksums (*.md5, > > *.sha1) > > > > for the source and binary artifacts can be found at: > > > > http://people.apache.org/~brock/flume-1.3.0-rc5/ > > > > > > > > Nexus Staging Repository: > > > > > https://repository.apache.org/content/repositories/orgapacheflume-059/ > > > > > > > > The tag to be voted on: > > > > http://s.apache.org/gC > > > > > > > > The KEYS file can be found here: > > > > https://svn.apache.org/repos/asf/flume/dist/KEYS > > > > > > > > > > > > > > > -- > > Apache MRUnit - Unit testing MapReduce - > > http://incubator.apache.org/mrunit/ > > > -- Apache MRUnit - Unit testing MapReduce - http://incubator.apache.org/mrunit/
