[ 
https://issues.apache.org/jira/browse/FLUME-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507922#comment-13507922
 ] 

Hudson commented on FLUME-1630:
-------------------------------

Integrated in flume-trunk #335 (See 
[https://builds.apache.org/job/flume-trunk/335/])
    FLUME-1630. Flume configuration code could be improved. (Revision 
97ed09e6f8255ee99ebb27cd10ef11a90830db24)

     Result = SUCCESS
hshreedharan : 
http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=97ed09e6f8255ee99ebb27cd10ef11a90830db24
Files : 
* 
flume-ng-node/src/test/java/org/apache/flume/node/TestAbstractLogicalNodeManager.java
* flume-ng-core/src/main/java/org/apache/flume/annotations/Disposable.java
* 
flume-ng-node/src/main/java/org/apache/flume/node/PropertiesFileConfigurationProvider.java
* flume-ng-node/src/test/java/org/apache/flume/node/TestFlumeNode.java
* flume-ng-core/src/main/java/org/apache/flume/SourceFactory.java
* 
flume-ng-node/src/main/java/org/apache/flume/conf/file/SimpleNodeConfiguration.java
* flume-ng-core/src/main/java/org/apache/flume/Constants.java
* 
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/JdbcChannel.java
* 
flume-ng-node/src/test/java/org/apache/flume/node/TestPollingPropertiesFileConfigurationProvider.java
* flume-ng-core/src/main/java/org/apache/flume/annotations/Recyclable.java
* flume-ng-node/src/main/java/org/apache/flume/node/NodeManager.java
* flume-ng-node/src/main/java/org/apache/flume/node/ConfigurationProvider.java
* 
flume-ng-core/src/test/java/org/apache/flume/source/TestDefaultSourceFactory.java
* flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java
* 
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java
* 
flume-ng-node/src/test/java/org/apache/flume/source/FlakeySequenceGeneratorSource.java
* flume-ng-node/src/test/java/org/apache/flume/node/TestApplication.java
* 
flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java
* flume-ng-core/src/main/java/org/apache/flume/SinkFactory.java
* 
flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java
* 
flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/NodeConfigurationAware.java
* 
flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/AbstractLogicalNodeManager.java
* 
flume-ng-node/src/test/java/org/apache/flume/node/TestDefaultLogicalNodeManager.java
* 
flume-ng-node/src/test/java/org/apache/flume/node/TestAbstractConfigurationProvider.java
* 
flume-ng-node/src/main/java/org/apache/flume/conf/file/AbstractFileConfigurationProvider.java
* 
flume-ng-node/src/test/java/org/apache/flume/node/TestPropertiesFileConfigurationProvider.java
* flume-ng-node/pom.xml
* flume-ng-node/src/main/java/org/apache/flume/node/Application.java
* flume-ng-core/src/main/java/org/apache/flume/ChannelFactory.java
* 
flume-ng-node/src/main/java/org/apache/flume/node/SimpleMaterializedConfiguration.java
* flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java
* 
flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/RecoverableMemoryChannel.java
* 
flume-ng-node/src/main/java/org/apache/flume/node/MaterializedConfiguration.java
* flume-ng-node/src/main/java/org/apache/flume/node/NodeConfiguration.java
* flume-ng-node/src/test/resources/flume-conf.properties
* flume-ng-core/src/test/java/org/apache/flume/sink/TestDefaultSinkFactory.java
* 
flume-ng-node/src/test/java/org/apache/flume/conf/properties/TestPropertiesFileConfigurationProvider.java
* flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java
* 
flume-ng-node/src/main/java/org/apache/flume/node/AbstractConfigurationProvider.java
* 
flume-ng-node/src/main/java/org/apache/flume/node/PollingPropertiesFileConfigurationProvider.java
* 
flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java
* 
flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java
* flume-ng-node/src/main/java/org/apache/flume/node/FlumeNode.java
* 
flume-ng-node/src/test/java/org/apache/flume/node/TestFlumeNodeApplication.java

                
> Flume configuration code could be improved
> ------------------------------------------
>
>                 Key: FLUME-1630
>                 URL: https://issues.apache.org/jira/browse/FLUME-1630
>             Project: Flume
>          Issue Type: Sub-task
>          Components: Configuration
>    Affects Versions: v1.3.0
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>         Attachments: FLUME-1630-0.patch, FLUME-1630-1.patch, 
> FLUME-1630-2.patch, FLUME-1630-5.patch, FLUME-1630-6.patch
>
>
> 1) It's not currently possible to provide your own configuration source
> 2) All sinks/sources/channels are reused, even across re-configurations which 
> they are not used
> 3) The flume-ng-node module is very complex and starts many threads which are 
> not required. That is there are multiple life cycle supervisors.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to