----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8365/#review14099 -----------------------------------------------------------
Looks quite good in general! A couple questions/comments below. flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java <https://reviews.apache.org/r/8365/#comment30164> unused variable flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java <https://reviews.apache.org/r/8365/#comment30167> Should the runPrivileged be outside the loop? flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java <https://reviews.apache.org/r/8365/#comment30166> Nit: This code will be somehwhat hot, debug statement could be done one when debug logging is enabled. - Brock Noland On Dec. 6, 2012, 7:48 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8365/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2012, 7:48 a.m.) > > > Review request for Flume. > > > Description > ------- > > Did some basic testing against secure and non-secure hbase. I will update > this patch as I test. This is an initial patch only, changes are likely. > > > This addresses bug FLUME-1726. > https://issues.apache.org/jira/browse/FLUME-1726 > > > Diffs > ----- > > flume-ng-sinks/flume-ng-hbase-sink/pom.xml 25422e1 > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java > 021ecd0 > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java > 62f7097 > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkSecurityManager.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/8365/diff/ > > > Testing > ------- > > > Thanks, > > Hari Shreedharan > >
