----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8387/#review14154 -----------------------------------------------------------
Looks good! One quick question to make sure I understand this correctly. If someone specifies no required channels the required channels list will just be empty and as such we'll only put the event on the optional channels. Similarly if there is no default channel and the event does not match a channel, the list returned will be empty? That makes sense to me, I just wanted to confirm. - Brock Noland On Dec. 6, 2012, 11:34 p.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8387/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2012, 11:34 p.m.) > > > Review request for Flume. > > > Description > ------- > > Added support for an optional channels only configuration. > > > This addresses bug FLUME-1768. > https://issues.apache.org/jira/browse/FLUME-1768 > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java > 866d9dc > > flume-ng-core/src/test/java/org/apache/flume/channel/TestMultiplexingChannelSelector.java > 9dff5bb > > Diff: https://reviews.apache.org/r/8387/diff/ > > > Testing > ------- > > Added 2 unit tests to test various sets of configs. > > > Thanks, > > Hari Shreedharan > >
