> On Dec. 7, 2012, 5:11 p.m., Brock Noland wrote: > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFileV3.java, > > line 52 > > <https://reviews.apache.org/r/8396/diff/2/?file=235283#file235283line52> > > > > I have recently found that parseDelimitedForm can return null. In this > > case we throw a NPE. Would it be possible to detect this and throw a > > BadCheckpointException()?
Yep. Makes sense. Will do. - Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8396/#review14157 ----------------------------------------------------------- On Dec. 7, 2012, 6:16 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8396/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2012, 6:16 a.m.) > > > Review request for Flume. > > > Description > ------- > > Added code to throw a BadCheckpointException, if we can recover from the > situation by deleting all files in the checkpoint directory. In the log > class, during startup if BadCheckpointException is caught, all files are > deleted and replay is retried. > > > This addresses bug FLUME-1762. > https://issues.apache.org/jira/browse/FLUME-1762 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/BadCheckpointException.java > PRE-CREATION > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFactory.java > 6c07152 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java > 5eaf8c2 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFileV2.java > 8bbc081 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFileV3.java > c24f89f > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventQueue.java > 36553c5 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java > 6d1cf51 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Serialization.java > ef8cf72 > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestEventQueueBackingStoreFactory.java > b1a55be > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java > 3f90805 > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFlumeEventQueue.java > 0173390 > > Diff: https://reviews.apache.org/r/8396/diff/ > > > Testing > ------- > > Added unit tests. Modified some existing unit tests to test for this change. > > > Thanks, > > Hari Shreedharan > >
