-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8127/
-----------------------------------------------------------

(Updated Dec. 10, 2012, 8:36 p.m.)


Review request for Flume.


Changes
-------

Update patch based on review. Attempts to resolves all deficiencies noted by 
the reviewer and myself.


Description
-------

Patch is on top of the FLUME-1502 branch which has 1630 committed to it.

This patch creates a module flume-ng-embedded-agent which implements 
FLUME-1502. The patch is not read for commit. Specifically, it needs the 
following:

1) whitespace removal
2) docs in package-info.java and the developer guide

However, I'd like to start soliciting feedback as these are not items which 
will affect it's overall design.


This addresses bug FLUME-1502.
    https://issues.apache.org/jira/browse/FLUME-1502


Diffs (updated)
-----

  
flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java
 5d56599 
  flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 
f39b919 
  flume-ng-dist/pom.xml d929c88 
  flume-ng-doc/sphinx/FlumeDeveloperGuide.rst f52970b 
  flume-ng-embedded-agent/pom.xml PRE-CREATION 
  
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgent.java
 PRE-CREATION 
  
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedAgentConfiguration.java
 PRE-CREATION 
  
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/EmbeddedSource.java
 PRE-CREATION 
  
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MaterializedConfigurationProvider.java
 PRE-CREATION 
  
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/MemoryConfigurationProvider.java
 PRE-CREATION 
  
flume-ng-embedded-agent/src/main/java/org/apache/flume/agent/embedded/package-info.java
 PRE-CREATION 
  
flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgent.java
 PRE-CREATION 
  
flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentConfiguration.java
 PRE-CREATION 
  
flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentEmbeddedSource.java
 PRE-CREATION 
  
flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentState.java
 PRE-CREATION 
  flume-ng-embedded-agent/src/test/resources/log4j.properties PRE-CREATION 
  
flume-ng-node/src/main/java/org/apache/flume/node/MaterializedConfiguration.java
 674fb38 
  pom.xml 53ac96b 

Diff: https://reviews.apache.org/r/8127/diff/


Testing
-------

Additional unit tests have been added and they pass.


Thanks,

Brock Noland

Reply via email to