----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8281/#review14268 -----------------------------------------------------------
Ship it! Ship It! - Hari Shreedharan On Nov. 29, 2012, 10:08 p.m., Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8281/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2012, 10:08 p.m.) > > > Review request for Flume. > > > Description > ------- > > 1) Gives Exception thrown in ComponentConfigurationFactory a better error > message > 2) FlumeConfiguration.validate* now logs exceptions as opposed to opaque > error message > > > This addresses bug FLUME-1745. > https://issues.apache.org/jira/browse/FLUME-1745 > > > Diffs > ----- > > > flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java > 6c151dc > > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java > 9b209e8 > > flume-ng-configuration/src/test/java/com/apache/flume/conf/TestFlumeConfiguration.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/8281/diff/ > > > Testing > ------- > > Unit tests pass and adds regression test for FLUME-1743. > > > Thanks, > > Brock Noland > >
