----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8379/#review14272 -----------------------------------------------------------
Ship it! Looks good. I added one really minor comment below. Feel free to ignore. When you are ready, please attach patch to jira. flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java <https://reviews.apache.org/r/8379/#comment30408> Isn't it always guaranteed that minimumRequiredSpace is >= FileChannelConfiguration.FLOOR_MINIMUM_REQUIRED_SPACE since the same comparison was made earlier in FileChannel.java? - Hari Shreedharan On Dec. 10, 2012, 11:28 p.m., Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8379/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2012, 11:28 p.m.) > > > Review request for Flume. > > > Description > ------- > > Adds a parameter which can be configured by defaults to 500MB. We will refuse > to checkpoint or perform log writes in this case. > > > This addresses bug FLUME-1763. > https://issues.apache.org/jira/browse/FLUME-1763 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java > 64a1350 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannelConfiguration.java > 92cad77 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java > 6d1cf51 > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLog.java > a165d6a > flume-ng-doc/sphinx/FlumeUserGuide.rst 21ca5cc > > Diff: https://reviews.apache.org/r/8379/diff/ > > > Testing > ------- > > Two unit tests added. > > > Thanks, > > Brock Noland > >
