----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7062/#review14304 -----------------------------------------------------------
Ship it! Ship It! - Brock Noland On Dec. 11, 2012, 7:29 p.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7062/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2012, 7:29 p.m.) > > > Review request for Flume. > > > Description > ------- > > Add checks to make sure they are positive, if not, reset to default. > > > This addresses bug FLUME-1571. > https://issues.apache.org/jira/browse/FLUME-1571 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java > 950ea8c > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestCheckpointRebuilder.java > ffc4623 > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java > 87a0a3f > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelFormatRegression.java > 184f956 > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java > f548f31 > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestUtils.java > 9978f86 > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/encryption/TestFileChannelEncryption.java > d2f5208 > flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java > 87a1305 > flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannel.java > e1a61c2 > > Diff: https://reviews.apache.org/r/7062/diff/ > > > Testing > ------- > > Added unit tests. > > > Thanks, > > Hari Shreedharan > >
