-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8369/
-----------------------------------------------------------

(Updated Dec. 14, 2012, 2:30 p.m.)


Review request for Flume.


Changes
-------

Update patch:

1) marks activemq as provided
2) Slightly changes Converter interface to allow for multiple flume events from 
a single JMS message


Description
-------

Implements FLUME-924 (JMS Source). Some notes:

1) Should work for any JMS provider but only tested with ActiveMQ.
2) Has unit tests as well as an ActiveMQ integration test
3) Allows for a pluggable class to convert a JMS message to a Flume Event. With 
that said, it provides a sensible default implementation.


This addresses bug FLUME-924.
    https://issues.apache.org/jira/browse/FLUME-924


Diffs (updated)
-----

  flume-ng-doc/sphinx/FlumeUserGuide.rst 265f546 
  flume-ng-sources/flume-jms-source/pom.xml PRE-CREATION 
  
flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/DefaultJMSMessageConverter.java
 PRE-CREATION 
  
flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/InitialContextFactory.java
 PRE-CREATION 
  
flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSDestinationType.java
 PRE-CREATION 
  
flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSMessageConsumer.java
 PRE-CREATION 
  
flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSMessageConsumerFactory.java
 PRE-CREATION 
  
flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSMessageConverter.java
 PRE-CREATION 
  
flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSource.java
 PRE-CREATION 
  
flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSourceConfiguration.java
 PRE-CREATION 
  
flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/JMSMessageConsumerTestBase.java
 PRE-CREATION 
  
flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestDefaultJMSMessageConverter.java
 PRE-CREATION 
  
flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestIntegrationActiveMQ.java
 PRE-CREATION 
  
flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestJMSMessageConsumer.java
 PRE-CREATION 
  
flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestJMSSource.java
 PRE-CREATION 
  flume-ng-sources/pom.xml 48f751d 
  pom.xml 6b465b2 

Diff: https://reviews.apache.org/r/8369/diff/


Testing
-------

The tests which were added, pass.


Thanks,

Brock Noland

Reply via email to