> On Dec. 18, 2012, 6:46 p.m., Hari Shreedharan wrote: > > flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSourceConfiguration.java, > > line 56 > > <https://reviews.apache.org/r/8607/diff/2/?file=238868#file238868line56> > > > > I think I missed this last time - shouldn't this be called > > converter.charset?
Good catch, will fix - Brock ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8607/#review14664 ----------------------------------------------------------- On Dec. 14, 2012, 9:25 p.m., Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8607/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2012, 9:25 p.m.) > > > Review request for Flume. > > > Description > ------- > > Fixes minor documentation problem and renames the converter parameter to be > consistent with other components. > > > This addresses bug FLUME-1784. > https://issues.apache.org/jira/browse/FLUME-1784 > > > Diffs > ----- > > flume-ng-doc/sphinx/FlumeUserGuide.rst 6490710 > > flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSource.java > e18b879 > > flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSourceConfiguration.java > 8a311c3 > > flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestJMSSource.java > 617393c > > Diff: https://reviews.apache.org/r/8607/diff/ > > > Testing > ------- > > Unit tests pass. > > > Thanks, > > Brock Noland > >
