-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8421/#review14705
-----------------------------------------------------------



flume-ng-node/src/main/java/org/apache/flume/node/AbstractConfigurationProvider.java
<https://reviews.apache.org/r/8421/#comment31183>

    Good catch!


- Brock Noland


On Dec. 18, 2012, 9:11 p.m., Brock Noland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8421/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2012, 9:11 p.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> Catches Exception around all the configure() methods of components. If they 
> throw an exception, they are removed from the configuration (not added).
> 
> 
> This addresses bug FLUME-1772.
>     https://issues.apache.org/jira/browse/FLUME-1772
> 
> 
> Diffs
> -----
> 
>   
> flume-ng-node/src/main/java/org/apache/flume/node/AbstractConfigurationProvider.java
>  daef76b 
>   
> flume-ng-node/src/test/java/org/apache/flume/node/TestAbstractConfigurationProvider.java
>  25001b1 
> 
> Diff: https://reviews.apache.org/r/8421/diff/
> 
> 
> Testing
> -------
> 
> Tests added for source, channel, and sink.
> 
> 
> Thanks,
> 
> Brock Noland
> 
>

Reply via email to