----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8845/#review15316 -----------------------------------------------------------
Hari, Looks good! I don't see any new docs, is this something that should be documented? A few comments below. flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java <https://reviews.apache.org/r/8845/#comment32980> We are just testing the layout functionality, correct? If so then only need to send a few events through? flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java <https://reviews.apache.org/r/8845/#comment32979> Would it be possible to get a comment or two as to what is going on with regards to the "level" variable? - Brock Noland On Jan. 6, 2013, 2:38 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8845/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2013, 2:38 a.m.) > > > Review request for Flume. > > > Description > ------- > > Added layout support to log4jappender. > > > This addresses bug FLUME-1818. > https://issues.apache.org/jira/browse/FLUME-1818 > > > Diffs > ----- > > > flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java > 083f5d1 > > flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java > 68d95fb > > Diff: https://reviews.apache.org/r/8845/diff/ > > > Testing > ------- > > Existing tests pass, added new test to test this feature. > > > Thanks, > > Hari Shreedharan > >
