----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9075/#review15635 -----------------------------------------------------------
I'm not too familiar with ganglia so will leave the review to someone else, but just tested this and it appears to work. No more message spam in /var/log/messages - Juhani Connolly On Jan. 23, 2013, 10:45 p.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9075/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2013, 10:45 p.m.) > > > Review request for Flume. > > > Description > ------- > > Added code to convert the value to float, if it fails, the type is set as > string. > > > This addresses bug FLUME-1870. > https://issues.apache.org/jira/browse/FLUME-1870 > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/instrumentation/GangliaServer.java > 8d34fee > > Diff: https://reviews.apache.org/r/9075/diff/ > > > Testing > ------- > > All unit tests pass. > > > Thanks, > > Hari Shreedharan > >
