If a committer +1-ed it, then you can ping the dev@ list to make sure it is 
committed (if the committer does not do it immediately). Else, you can ask the 
committers to review it by pinging the dev@ list or updating the jira. 

Hari 

-- 
Hari Shreedharan


On Friday, January 25, 2013 at 2:05 PM, Roshan Naik wrote:

> what about the ones that say 'ship it' but not committed ? (FLUME-1661)
> 
> 
> On Fri, Jan 25, 2013 at 7:13 AM, Brock Noland <[email protected] 
> (mailto:[email protected])> wrote:
> 
> > +1
> > 
> > I'll check mine today.
> > 
> > On Thu, Jan 24, 2013 at 9:20 PM, Jarek Jarcec Cecho <[email protected] 
> > (mailto:[email protected])>
> > wrote:
> > > Thanks for reminding Juhani, I've closed all my opened reviews.
> > > 
> > > Jarcec
> > > 
> > > On Fri, Jan 25, 2013 at 11:02:23AM +0900, Juhani Connolly wrote:
> > > > Hi guys,
> > > > could you just check your open tickets on review board("all my
> > > > requests") and close up any that have been committed or discarded?
> > > > Looked like there was a lot of backlog but it turns out many of the
> > > > tickets have already been committed, hard to distinguish them from
> > > > ones that need review. A couple of them also don't have "ship it"
> > > > but have been committed.
> > > > 
> > > > Thanks,
> > > > Juhani
> > > > 
> > > 
> > > 
> > 
> > 
> > 
> > 
> > --
> > Apache MRUnit - Unit testing MapReduce -
> > http://incubator.apache.org/mrunit/
> > 
> 
> 
> 


Reply via email to