> On Feb. 1, 2013, 3:20 p.m., Brock Noland wrote: > > Looks, good, I will run tests in a hour and commit if they pass. > > Hari Shreedharan wrote: > Thanks Brock. I will submit a new patch with 2 more test cases (no code > changes). Could you please hold of the commit till then? Thanks!
sure will do - Brock ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9240/#review16011 ----------------------------------------------------------- On Feb. 1, 2013, 8:47 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9240/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2013, 8:47 a.m.) > > > Review request for Flume. > > > Description > ------- > > Fast replay is now run only if checkpoint file does not exist. > > > This addresses bug FLUME-1891. > https://issues.apache.org/jira/browse/FLUME-1891 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java > d921387 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java > 8a4201c > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java > ea57cdb > > Diff: https://reviews.apache.org/r/9240/diff/ > > > Testing > ------- > > Added 2 unit tests to test for the case where checkpoint does not exist (or > is corrupt) and where checkpoint exists. > > > Thanks, > > Hari Shreedharan > >
