-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9283/
-----------------------------------------------------------

Review request for Flume.


Description
-------

Initial implementation of Thrift RPC client. I will add some comments on why 
the exception handling is done by catching and sending the errors as part of 
the result.  I had to change some of the pom.xml files which generate thrift 
java files, because the mvn-thrift plugin is no longer on maven. So, changed 
the generation code to the one I used. Generating the code requires thrift 
0.6.1 - since there is no .thrift file for scribe sources, and thrift generated 
code is backwards incompatible between 0.9 and 0.6.1.


This addresses bug FLUME-1896.
    https://issues.apache.org/jira/browse/FLUME-1896


Diffs
-----

  flume-ng-channels/flume-file-channel/pom.xml 2408447 
  
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java
 d921387 
  
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java
 8a4201c 
  
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java
 ea57cdb 
  flume-ng-core/pom.xml ba414bc 
  flume-ng-legacy-sources/flume-thrift-source/pom.xml b9667cd 
  flume-ng-sdk/pom.xml ab066d5 
  flume-ng-sdk/src/main/java/org/apache/flume/api/thrift/ThriftRpcClient.java 
PRE-CREATION 
  flume-ng-sdk/src/main/thrift/aslv2 PRE-CREATION 
  flume-ng-sdk/src/main/thrift/flume.thrift PRE-CREATION 
  
flume-ng-sdk/src/test/java/org/apache/flume/api/thrift/TestThriftRpcClient.java 
PRE-CREATION 
  
flume-ng-sdk/src/test/java/org/apache/flume/api/thrift/ThriftTestingSource.java 
PRE-CREATION 
  flume-ng-sinks/flume-hdfs-sink/pom.xml aaa0e1f 
  
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java
 3f31ef2 
  
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkSecurityManager.java
 8bf0509 
  flume-ng-sources/flume-scribe-source/pom.xml 588207d 
  pom.xml 5d59d44 

Diff: https://reviews.apache.org/r/9283/diff/


Testing
-------

Added some unit tests. 


Thanks,

Hari Shreedharan

Reply via email to