> On Feb. 10, 2013, 9:04 p.m., Brock Noland wrote: > > Looks great! A few comments below. Also, does this have to be added to the > > dist pom? I know I have had trouble with things like the JMS source because > > I didn't add it to the n requisite places.
No. None of these add new modules. All of them are added to the existing modules, so we don't need to add it to the dist pom. > On Feb. 10, 2013, 9:04 p.m., Brock Noland wrote: > > flume-ng-core/src/test/java/org/apache/flume/source/TestThriftSource.java, > > line 64 > > <https://reviews.apache.org/r/9352/diff/4/?file=257024#file257024line64> > > > > This is a more reliable mechanism to find a free port: > > > > ServerSocket socket = new ServerSocket(0); > > int port = socket.getLocalPort(); > > socket.close(); Ok, I will add it in a follow-up jira, since I need to update this in TestThriftRpcClient code too, which means I will need to update that patch too (if I update it here, rb will complain that the file does not exist). So I will update both once both these are committed - Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9352/#review16398 ----------------------------------------------------------- On Feb. 8, 2013, 9:36 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9352/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2013, 9:36 a.m.) > > > Review request for Flume. > > > Description > ------- > > Thrift Source. > > > This addresses bug FLUME-1898. > https://issues.apache.org/jira/browse/FLUME-1898 > > > Diffs > ----- > > > flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java > 3312b04 > > flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java > 058ca1c > flume-ng-core/pom.xml 7db4f23 > flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java > PRE-CREATION > flume-ng-core/src/test/java/org/apache/flume/source/TestThriftSource.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/9352/diff/ > > > Testing > ------- > > Added several unit tests. > > > Thanks, > > Hari Shreedharan > >
