----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9532/#review17121 -----------------------------------------------------------
Ship it! +1 looks good, unit tests pass - Mike Percy On Feb. 26, 2013, 10:32 p.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9532/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2013, 10:32 p.m.) > > > Review request for Flume. > > > Description > ------- > > Add a new configuration param to optionally set the timestamp at the sink. > > > This addresses bug Flume-1922. > https://issues.apache.org/jira/browse/Flume-1922 > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java > fcc26f2 > > flume-ng-core/src/test/java/org/apache/flume/formatter/output/TestBucketPath.java > 090b3a8 > flume-ng-doc/sphinx/FlumeUserGuide.rst 8a4ecda > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java > e980d13 > > flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java > cdddd50 > > Diff: https://reviews.apache.org/r/9532/diff/ > > > Testing > ------- > > Added a unit test. All current tests pass. > > > Thanks, > > Hari Shreedharan > >
