[
https://issues.apache.org/jira/browse/FLUME-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601894#comment-13601894
]
Mike Percy commented on FLUME-997:
----------------------------------
Hi Joey,
Upon initial review, the changes look good.
The patch definitely needs a rebase though. I tried to do a simple merge but
the files in your patch were heavily modified in the past few weeks, so it will
take a human touch to get your changes to apply. Note that most of the
implementation of the AvroSink moved into AbstractRpcSink as part of FLUME-1897.
Some general things to keep in mind, since Ted's patch has been committed now:
1. SSL should always wrap the compression, if enabled
2. Watch out for DRY in the AvroSource, especially now that the compression
stuff is checked in
3. Would be great to get negative test cases for non-SSL clients to ensure SSL
servers don't work with them
I'm interested in getting this in, let me know how I can help.
> Support secure transport mechanism
> ----------------------------------
>
> Key: FLUME-997
> URL: https://issues.apache.org/jira/browse/FLUME-997
> Project: Flume
> Issue Type: New Feature
> Affects Versions: v1.0.0
> Reporter: Mike Percy
> Labels: security
> Fix For: v1.4.0
>
> Attachments: FLUME-997-1.patch
>
>
> Flume needs support for a secure network transport protocol. See AVRO-898 for
> a patch that made it into Avro 1.6.0 that allows us to do this relatively
> easily.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
