[
https://issues.apache.org/jira/browse/FLUME-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13613008#comment-13613008
]
Hari Shreedharan commented on FLUME-1957:
-----------------------------------------
Israel,
Thanks for the patch! Generally looks good. I have a couple minor suggestions:
* Could you please add an @Override to the stop() method?
* In the logs printed out on stop (the channel size message), could you also
add the name of the component. The name field is private in
MonitoredCounterGroup - you can either make it protected or add a getter.
> FileChannel should print channel size when it stops
> ---------------------------------------------------
>
> Key: FLUME-1957
> URL: https://issues.apache.org/jira/browse/FLUME-1957
> Project: Flume
> Issue Type: Bug
> Affects Versions: v1.4.0
> Reporter: Hari Shreedharan
> Assignee: Israel Ekpo
> Labels: patch
> Attachments: FLUME-1957.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
