[
https://issues.apache.org/jira/browse/FLUME-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13614948#comment-13614948
]
Mike Percy commented on FLUME-1621:
-----------------------------------
Thanks for the patch Israel, looks pretty good but I have a couple suggestions:
1. transactionCapacity is basically a safeguard, a sanity check, and any
component that tries to put() or take() more than that number of events in a
single transaction will get an exception thrown when they try. So we shouldn't
characterize it as just a sink thing.
2. In the example, making the capacity a power of 2 seems a bit confusing to me
since it kind of seems like we're using 1KB of memory or something. A nice even
number of events (like a power of ten) seems more natural to me. But setting it
to a larger number such as 1000000 for memory channel seems realistic, that
might be a better option. transactionCapacity would typically be set to a
significantly smaller number than capacity. I'd say maybe 10000 is the largest
batch size that is typically helpful.
> Document new MemoryChannel parameters in Flume User Guide
> ---------------------------------------------------------
>
> Key: FLUME-1621
> URL: https://issues.apache.org/jira/browse/FLUME-1621
> Project: Flume
> Issue Type: Bug
> Components: Channel
> Affects Versions: v1.3.0
> Reporter: Hari Shreedharan
> Assignee: Israel Ekpo
> Fix For: v1.4.0
>
> Attachments: FLUME-1621.patch
>
>
> New parameters were added in FLUME-1535. We should add these to the Flume
> User Guide.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
