> On April 9, 2013, 8:46 p.m., Hari Shreedharan wrote: > > flume-ng-core/src/main/java/org/apache/flume/channel/BasicTransactionSemantics.java, > > line 182 > > <https://reviews.apache.org/r/10362/diff/1/?file=279141#file279141line182> > > > > I agree with Brock. This should not be the case. The file channel can > > lose data if we don't rollback (unless there is a replay)
Yeah that is a good point. The file channel needs rollback to be called.... - Brock ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10362/#review18884 ----------------------------------------------------------- On April 9, 2013, 3:21 a.m., Roshan Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10362/ > ----------------------------------------------------------- > > (Updated April 9, 2013, 3:21 a.m.) > > > Review request for Flume. > > > Description > ------- > > Loggin error instead of throwing exception in cases where close() is called > w/o rollback or abort being called. > > > This addresses bug FLUME-1321. > https://issues.apache.org/jira/browse/FLUME-1321 > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/channel/BasicTransactionSemantics.java > 403cbca > > Diff: https://reviews.apache.org/r/10362/diff/ > > > Testing > ------- > > > Thanks, > > Roshan Naik > >
