----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10453/#review19149 -----------------------------------------------------------
Hi Mike, thank you for your patch, I do have just a few nits: bin/flume-ng <https://reviews.apache.org/r/10453/#comment39725> It seems that we always take the last --plugin-dirs parameter into account. Is it intentional or would we prefer multiple entries similarly as we are accepting with "-D"? E.g.: opt_plugins_dirs="$opt_plugins_dirs $1" bin/flume-ng <https://reviews.apache.org/r/10453/#comment39726> Nit: Trailing whitespace bin/flume-ng <https://reviews.apache.org/r/10453/#comment39727> Nit: Trailing whitespace bin/flume-ng <https://reviews.apache.org/r/10453/#comment39728> Nit: Trailing whitespace Jarcec - Jarek Cecho On April 15, 2013, 12:09 a.m., Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10453/ > ----------------------------------------------------------- > > (Updated April 15, 2013, 12:09 a.m.) > > > Review request for Flume. > > > Description > ------- > > Added capability to specify one or more plugins directories on the command > line. > > > This addresses bug FLUME-1948. > https://issues.apache.org/jira/browse/FLUME-1948 > > > Diffs > ----- > > bin/flume-ng ee86c95 > > Diff: https://reviews.apache.org/r/10453/diff/ > > > Testing > ------- > > Manually tested with config file and 2 plugins.d directories > > > Thanks, > > Mike Percy > >
