[
https://issues.apache.org/jira/browse/FLUME-2004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13634714#comment-13634714
]
Mike Percy commented on FLUME-2004:
-----------------------------------
Hi [~venkyz],
Thanks for the patch! The changes look pretty good. I have one suggestion and a
couple of requests for you:
1. In ExecSource on line 298 and 304 we are incrementing the same counter via
{{addToEventAcceptedCount()}}. The call on line 298 should be removed.
2. What kind of testing has been done on this so far? Can we add a unit test
for this functionality?
3. After updating the patch, please also post your change to [review
board|http://reviews.apache.org/groups/Flume/] and post a link to your review
here on this JIRA. Review board makes it easier for committers to review your
changes and provide feedback.
I didn't test this yet but other than that, the changes look good to me.
Regards,
Mike
> Need to capture metrics on the Flume exec source such as events received,
> rejected, etc.
> ----------------------------------------------------------------------------------------
>
> Key: FLUME-2004
> URL: https://issues.apache.org/jira/browse/FLUME-2004
> Project: Flume
> Issue Type: New Feature
> Components: Channel, Sinks+Sources
> Affects Versions: v1.3.0
> Reporter: Robert Justice
> Priority: Minor
> Attachments: FLUME-2004.patch
>
>
> To give you a background, we have configured our flume agents with "exec"
> source to tail some logs and stream it to a set of collectors. We have
> monitoring setup that polls "/metrics" on these agents and verifies a few
> metrics like channel size, event put count etc. The "/metrics" response
> returns data about the 'channel' and 'sink' (we have an avro sink)
> components, however there is no data returned about the "source" (exec)
> component. We are interested in monitoring the number of events received,
> rejected, etc.
> I couldn't find any documentation around this; I checked the flume source and
> saw the metrics are not getting captured in the code as well for 'exec'
> source.
> Please improve the metrics captured for the 'exec' source for flume.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
