[ 
https://issues.apache.org/jira/browse/FLUME-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639193#comment-13639193
 ] 

Edward Sargisson commented on FLUME-2015:
-----------------------------------------

I've been thinking about this overnight - this is a great patch:

* I think FLUME-1972 should be abandoned in favour of this patch - this patch 
is a much more generic and usable way to achieve the same goal. I also think 
the ElasticSearchEventSerializer2 interface from FLUME-1782 should be abandoned 
in favour of this patch.
* I still think its name should be ElasticSearchIndexRequestBuilderFactory.
* We should consider what we want to do with the possibly generated timestamp 
and the index name. We could pass both of those to the 
ElasticSearchIndexRequestBuilderFactory - or we could move the timestamp and 
index name generation to a default and/or abstract 
ElasticSearchIndexRequestBuilderFactory.
* We will need to update the Flume User Guide.

I'm not sure I can justify using my employer's time on this - at least not for 
a few days.

                
> ElasticSearchSink: need access to IndexRequestBuilder instance during flume 
> event processing
> --------------------------------------------------------------------------------------------
>
>                 Key: FLUME-2015
>                 URL: https://issues.apache.org/jira/browse/FLUME-2015
>             Project: Flume
>          Issue Type: Improvement
>          Components: Sinks+Sources
>    Affects Versions: v1.3.0, v1.3.1
>            Reporter: Tim Bacon
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> I need more control over the indexing performed by the {{ElasticSearchSink}} 
> -- in particular I need access to an {{IndexRequestBuilder}} instance during 
> flume event processing. The interactions between {{ElasticSearchSink}} and 
> {{ElasticSearchEventSerializer}} currently do not make this possible.
> I have authored a patch that meets my needs and maintains 
> backwards-compatibility for existing users of the sink. It is available at 
> [https://github.com/prime8/flume/commit/1056c129b10c95cee50e0c3f77e309668f82bfc6]
>  -- please let me know if it can be pulled into the main ASF source tree!
> Thanks :-)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to