[ 
https://issues.apache.org/jira/browse/FLUME-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639715#comment-13639715
 ] 

Hari Shreedharan commented on FLUME-1819:
-----------------------------------------

Also, could you add a unit test to test this case? Also, passing the Long 
"lastflush" does not update the original long when it is updated inside the 
runnable (yes, the weirdness of Java pass-by-value - that even for wrapper 
classes, the reference to the wrapper object is not what is passed) - you can 
make the runnable a private class so you can access the lastPush variable 
(there is no need for it to be static, it does not seem like it has any value 
without an exec source instance) - also, this way you don't need to pass in all 
of the other fields.
                
> ExecSource don't flush the cache if there is no input entries
> -------------------------------------------------------------
>
>                 Key: FLUME-1819
>                 URL: https://issues.apache.org/jira/browse/FLUME-1819
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.3.0
>            Reporter: Fengdong Yu
>            Assignee: Venkatesh Sivasubramanian
>             Fix For: v1.4.0
>
>         Attachments: FLUME-1819.patch, FLUME-1819.patch.1, FLUME-1819.patch.2
>
>
> ExecSource has a default batchSize: 20, exec source read data from the 
> source, then put it into the cache, after the cache is full, push it to the 
> channel.
> but if exec source's cache is not full, and there isn't any input for a long 
> time, then these entries always kept in the cache, there is no chance to the 
> channel until the source's cache is full.
> so, the patch added a new config line: batchTimeout for ExecSource, and 
> default is 3 seconds, if batchTimeout exceeded, push all cached data to the 
> channel even the cache is not full.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to