[
https://issues.apache.org/jira/browse/FLUME-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Edward Sargisson updated FLUME-2015:
------------------------------------
Attachment: FLUME-2015-doc-1.4.0-0.patch
Hi Tim,
I've just reviewed your new patch and it's nice work. I think you should
proceed with the next step of setting up a review on the Review Board:
https://reviews.apache.org. I believe Israel provided you with details on how
to do this.
I've just written what I think the docs should say (given all the other changes
I think should be made to the docs) and include it here as
FLUME-2015-doc-1.4.0-0.patch. This is a separate patch to the code patch you
provided.
In our local environment I have built a version of 1.4.0 with your patch,
modified our extensions to work with it and run it through our continuous
integration tests successfully.
Comments:
* I note that you didn't include the code to warn periodically when the
timestamp is not provided. In my view, I think the operators should be warned
of this because it affects the timestamp the events are written with - and thus
how they can be found.
* I note that you copy the entire event in order to wrap it into a
TimestampEvent. I was initially concerned because this would lead to a lot of
garbage - leading to large GC pauses. However, I've convinced myself that the
new objects are too short lived for this to matter. I would have preferred
keeping the original event and passing the timestamp along beside it.
> ElasticSearchSink: need access to IndexRequestBuilder instance during flume
> event processing
> --------------------------------------------------------------------------------------------
>
> Key: FLUME-2015
> URL: https://issues.apache.org/jira/browse/FLUME-2015
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.3.0, v1.3.1
> Reporter: Tim Bacon
> Attachments: FLUME-2015-1.4.0-0.patch, FLUME-2015-doc-1.4.0-0.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> I need more control over the indexing performed by the {{ElasticSearchSink}}
> -- in particular I need access to an {{IndexRequestBuilder}} instance during
> flume event processing. The interactions between {{ElasticSearchSink}} and
> {{ElasticSearchEventSerializer}} currently do not make this possible.
> I have authored a patch that meets my needs and maintains
> backwards-compatibility for existing users of the sink. It is available at
> [https://github.com/prime8/flume/commit/1056c129b10c95cee50e0c3f77e309668f82bfc6]
> -- please let me know if it can be pulled into the main ASF source tree!
> Thanks :-)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
